Homu retry log - rust

@bors r- retry (bors seems to think this PR is approved and is not running a try-only build?)

@bors retry

@bors retry

@bors retry

@bors retry

Clearly another CI issue.

@bors retry

...failed to download tidy-html?
Let's try again.
@bors retry

>   --- stderr -------------------------------
>   thread 'main' panicked at src/tools/remote-test-client/src/main.rs:310:9:
>   client.read_exact(&mut header) failed with Connection reset by peer (os error 104)
>   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


Suspicious and not related. @bors retry

@bors retry

@bors retry

@bors retry r-

@bors retry

DNS…

@bors retry remote-test-client failure

Failed to push the docker image.

@bors retry

@bors retry

> ##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled

@bors retry

@bors retry Connection reset by peer in remote-test-client

@bors retry

@bors retry

I'm not sure what caused the error.

@bors retry rollup=never p=1

@bors retry r-

> ⌛ Testing commit [ed532cc](https://github.com/rust-lang/rust/commit/ed532cc186a651a3e4b848ffbef8c080018f1732) with merge [4d96c3e](https://github.com/rust-lang/rust/commit/4d96c3efd8f1abcc82a7148c5ec0657bd486571e)...

That's a zombie.

@bors retry for good measure.

> ⌛ Testing commit [c19866f](https://github.com/rust-lang/rust/commit/c19866f335152cbdd3424b573e5a615963dbe80e) with merge [460356f](https://github.com/rust-lang/rust/commit/460356fe8b94d18fde00d2f167653e6f33513f09)...

That's a zombie.

@bors retry for good measure

@bors retry

@bors retry

@bors retry

It looks like we do in fact use the right one for the appleOS platforms: https://github.com/rust-lang/rust/blob/f705de59625bb76067a5d102edc1575ff23b8845/library/core/src/ffi/mod.rs#L207-L235

Yeah I think it was just a timeout.

@bors retry

@bors retry

@bors retry

@bors retry

@bors retry

@bors retry

Posted https://github.com/rust-lang/cargo/pull/13811 to fix the flaky test.

@bors retry yield to rollup

@bors retry

@bors retry

Looks spurious. @bors retry

@bors retry

@bors retry

For good measure: @bors retry

@bors retry

Seems flaky.

@bors retry

Another instance of https://github.com/rust-lang/rust/issues/123583.
@bors retry

Looks like a flaky test in miri, other PRs have run into that too.

@bors retry

wtf ci

@bors retry

@bors retry

Looks unrelated

@bors retry

@bors retry (flaky ci)

@bors retry

401 Unauthorized docker accessing ghcr.io 

@bors retry

#97669 armhf-gnu failed

@bors retry

@bors retry

what

@bors retry 

As long as it's not a timeout, which this doesn't appear to be, then I think we can just retry.

@bors retry

@bors retry

@bors retry

@bors retry

@bors retry

@bors retry

what the heck lol

@bors retry

@bors retry yield to rollup

@bors retry - miri reports a memory leak but I doubt it's related to this PR (#123961 for follow-up)

@bors retry

Looks like an instance of https://github.com/rust-lang/rust/issues/123583.
@bors retry

Failed in miri on i686-pc-windows-gnu. However this PR only affects msvc, aside from changing some `libc` imports to be `core::ffi` ones so it's unlikely to be caused by this PR. @rust-lang/miri 

<details><summary>i686-pc-windows-gnu miri</summary>

```  
  error: memory leaked: alloc27197638 (Rust heap, size: 8, align: 4), allocated here:
  Error:     --> /checkout/library/alloc/src/alloc.rs:100:9
       |
  100  |         __rust_alloc(layout.size(), layout.align())
       |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = note: BACKTRACE:
       = note: inside `realstd::alloc::alloc` at /checkout/library/alloc/src/alloc.rs:100:9: 100:52
       = note: inside `realstd::alloc::Global::alloc_impl` at /checkout/library/alloc/src/alloc.rs:183:73: 183:86
       = note: inside `<realstd::alloc::Global as core::alloc::Allocator>::allocate` at /checkout/library/alloc/src/alloc.rs:243:9: 243:39
       = note: inside `alloc_crate::alloc::exchange_malloc` at /checkout/library/alloc/src/alloc.rs:332:11: 332:34
       = note: inside `realstd::boxed::Box::<realstd::sys::thread_local::os_local::Value<u8>>::new` at /checkout/library/alloc/src/boxed.rs:218:9: 218:20
       = note: inside `realstd::thread::local_impl::Key::<u8>::try_initialize::<{closure@/checkout/library/std/src/sys/thread_local/os_local.rs:28:27: 28:34}>` at /checkout/library/std/src/sys/thread_local/os_local.rs:145:37: 145:94
       = note: inside `realstd::thread::local_impl::Key::<u8>::get::<{closure@/checkout/library/std/src/sys/thread_local/os_local.rs:28:27: 28:34}>` at /checkout/library/std/src/sys/thread_local/os_local.rs:127:18: 127:43
  note: inside `sync::reentrant_lock::current_thread_unique_ptr::X::__getit`
      --> /checkout/library/std/src/sys/thread_local/os_local.rs:28:17
       |
  11   |   pub macro thread_local_inner {
       |   ----------------------------
       |   |
       |   in this expansion of `$crate::thread::local_impl::thread_local_inner!` (#2)
       |   in this expansion of `$crate::thread::local_impl::thread_local_inner!` (#3)
  ...
  28   | /                 __KEY.get(move || {
  29   | |                     if let $crate::option::Option::Some(init) = _init {
  30   | |                         if let $crate::option::Option::Some(value) = init.take() {
  187 | |     () => {};
  ...   |
  195 | |         $crate::thread::local_impl::thread_local_inner!($(#[$attr])* $vis $name, $t, const $init);
      | |         ----------------------------------------------------------------------------------------- in this macro invocation (#2)
  ...   |
  207 | |     );
  208 | | }
      | |_- in this expansion of `thread_local!` (#1)
      = note: inside `realstd::thread::LocalKey::<u8>::try_with::<{closure@library/std/src/sync/reentrant_lock.rs:319:12: 319:15}, usize>` at /checkout/library/std/src/thread/local.rs:285:37: 285:55
      = note: inside `realstd::thread::LocalKey::<u8>::with::<{closure@library/std/src/sync/reentrant_lock.rs:319:12: 319:15}, usize>` at /checkout/library/std/src/thread/local.rs:262:9: 262:25
  note: inside `sync::reentrant_lock::current_thread_unique_ptr`
     --> library/std/src/sync/reentrant_lock.rs:319:5
      |
  319 |     X.with(|x| <*const _>::addr(x))
      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  note: inside `sync::reentrant_lock::ReentrantLock::<()>::try_lock`
     --> library/std/src/sync/reentrant_lock.rs:226:27
      |
  226 |         let this_thread = current_thread_unique_ptr();
      |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  note: inside closure
     --> library/std/src/sync/reentrant_lock/tests.rs:47:20
      |
  47  |         let lock = l2.try_lock();
      |                    ^^^^^^^^^^^^^
```

</details>

@bors retry miri i686-pc-windows-gnu std

@bors retry "   Error: The operation was canceled."

Seems spurious, considering this PR doesn't affect Linux

@bors retry

Seems irrelevant to cargo

@bors retry

@bors retry

@bors retry

@bors retry

@bors retry yield to a rollup

@bors retry

🤔 
CI failure?

@bors retry

@bors retry

@bors retry

Backported a fix for the tidy issue we saw in https://github.com/rust-lang/rust/pull/123681#issuecomment-2045723120.

@bors retry r+ p=500 rollup=never

@bors retry

Yielding priority to the stable release.

@raoulstrackx those tests do run in the `test-various` job -- [here](https://github.com/rust-lang-ci/rust/actions/runs/8566085241/job/23475198435#step:27:27372) it is in the most recent logs. Search for "suite=assembly" if that link doesn't take you to the right line. They also pass in my local build. I wonder what's different in your CI?

---

Not sure why bors didn't react to CI completion here -- let's have another go...

@bors retry

I can reproduce the miri issue without this change. I have a working theory, but I'll see if I can minimize the example first.

As it's an unrelated failure, it's not blocking this PR.
@bors retry

@bors retry

@bors retry

@bors retry